| ... | ... | @@ -135,25 +135,20 @@ See [this resource](https://mifactori.de/non-commercial-is-not-open-source/) for |
|
|
|
|
|
|
|
Short answer: File upstream. You can comment that in the review (since this may relevant for other reviewers as well). More important is to report this in the original repository so the developers can take care of it. If you're struggling with it or don't find the time, CAB admins are always there to help you out.
|
|
|
|
|
|
|
|
# Feedback
|
|
|
|
|
|
|
|
The workflow is still under development. Frankly speaking, since it is open source, it will always be an evolutional process, which is one of the strengths of the community driven design.
|
|
|
|
|
|
|
|
Therefore we invite you to contribute in our development. First of all we would highly appreciate your feedback on all your workflow experiences. Please feel free to create as many issues as you like inside here: [CAB Feedback](https://gitlab.opensourceecology.de/verein/projekte/cab/CAB/-/milestones/4)-Area.
|
|
|
|
## Bugfixing and project updates
|
|
|
|
|
|
|
|
* What was your experience?
|
|
|
|
* What difficulties did you face?
|
|
|
|
* How did you solve them?
|
|
|
|
* Was the information provied helpfull?
|
|
|
|
* What did you miss and how would you have wished it to be?\
|
|
|
|
Be free. Be creative. We are counting on you ⭐
|
|
|
|
To fix the problems pointed out by the reviewers:
|
|
|
|
- For bigger changes: Start a new branch
|
|
|
|
- Ideally edit only one part per commit
|
|
|
|
- Apply the changes and commit them as **merge request** into the **review branch!**
|
|
|
|
- **When commiting tag the relevant issue you fixed!!!**
|
|
|
|
- This is very important, so reviewers and CAB-admin can comprehend the change history
|
|
|
|
- The reviewers will check the merge request and update the relevant issues
|
|
|
|
|
|
|
|
Some specific questions for our reviewers:
|
|
|
|
In some cases Reviewers might also directly apply changes fixing their complain. In this case they should follow the same guidelines but the changes should be approved by the applicants, respectively the project developers.
|
|
|
|
|
|
|
|
* what aspects did you review?
|
|
|
|
* what details did you look at?
|
|
|
|
* was it your first review?
|
|
|
|
* was the process clear to you?
|
|
|
|
* did you know what to look at, what questions to answer?
|
|
|
|
* how much time did you take?
|
|
|
|
* what (technical) specification of the review process would you wish for as guidance? |
|
|
\ No newline at end of file |
|
|
|
## Finishing
|
|
|
|
|
|
|
|
Once all parts are approved the assessment will be finished and the project will receive the community conformity by means of a specially tagged version. The project will be listed in the assessment overview as approved and the review branch |
